Skip to content

Update Register.svelte #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update Register.svelte #4

wants to merge 1 commit into from

Conversation

tnylea
Copy link

@tnylea tnylea commented Mar 5, 2025

This will fix the Registration functionality. Right now it does not seem to be working on my end because the form does a full page request and never ends up submitting.

This will fix that issue.

Fixing the registration by adding prevent default on the form
@oseughu
Copy link
Owner

oseughu commented Mar 6, 2025

This will fix the Registration functionality. Right now it does not seem to be working on my end because the form does a full page request and never ends up submitting.

This will fix that issue.

thanks a lot for spotting that, I have seen the problem, the proper way to fix this would be

 const submit = (e: Event) => {
        e.preventDefault();
        $form.post(route('register'), {
            onFinish: () => $form.reset('password', 'password_confirmation'),
        });
 };

the fix you proposed is a Svelte 4 method that's deprecated

@tnylea
Copy link
Author

tnylea commented Mar 6, 2025

Ok, cool. Feel free to close this issue and add that updated functionality so that way the registration works. I want to collect a list of starter kits that will work with the new installer: https://x.com/taylorotwell/status/1897375982144967156.

Can you submit this to Packagist so that way users can use this starter kit in the Laravel installer.

Thanks!

@oseughu
Copy link
Owner

oseughu commented Mar 6, 2025

alrighty no problem, I put it on packagist yesrerday so I'm good to go. Once again well done with the starter kits, I love them!

@oseughu oseughu closed this Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants